-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1843 - limit cache when close to tip #1886
Conversation
73a8fa6
to
34bceb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optimiseCaches
requires fixing.
Also optomise
is sometimes used instead of optimise
. Using reduce
instead of optimise would also make it more specific, since the cache is reduced.
Finally, using patterns as suggested could reduce the cases.
46a3f01
to
54fcebb
Compare
54fcebb
to
a28f1de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
possibly the new boolean flag need to become a TVar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few stylistic changes and this is good to go
1db8911
to
26346a2
Compare
Description
This fixes #1843
Checklist
fourmolu
on version 0.10.1.0 (which can be run withscripts/fourmolize.sh
)Migrations
If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.