Performance Improvement: high-requency listener #4402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedstoneFuture
commented
Apr 16, 2024
| @@ -164,114 +151,6 @@ public static void sendBlockChange(final org.bukkit.Location bloc, final BlockDa | |||
| }, TaskTime.ticks(3L)); | |||
| } | |||
|
|
|||
| @EventHandler | |||
| public void onRedstoneEvent(BlockRedstoneEvent event) { | |||
There was a problem hiding this comment.
Moved to a separate class without making any changes.
RedstoneFuture
commented
Apr 16, 2024
| } | ||
|
|
||
| @EventHandler(ignoreCancelled = true, priority = EventPriority.HIGHEST) | ||
| public void onPhysicsEvent(BlockPhysicsEvent event) { |
There was a problem hiding this comment.
Moved to a separate class without making any changes.
RedstoneFuture
commented
Apr 16, 2024
| private static final Set<Material> PHYSICS_BLOCKS = Set.of( | ||
| Material.TURTLE_EGG, | ||
| Material.TURTLE_SPAWN_EGG | ||
| ); |
There was a problem hiding this comment.
These sets were only used in the methods involved and could/must also be moved.
SirYwell
approved these changes
Apr 21, 2024
dordsor21
approved these changes
May 12, 2024
pull bot
pushed a commit
to Craftstuebchen/PlotSquared
that referenced
this pull request
May 16, 2024
* Adding new 'high-frequency-listener' setting * Moving high-frequency event listener in new class * Small typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As we know, the
BlockPhysicsEventis called very often, while not everyone needs the associated settings or flags.With this PR I would like to outsource two high-frequency event-listeners to a separate class that can be explicitly deactivated in the
settings.yml.Description
high-frequency-listenersetting (same setting names as the setting in WorldGuard):onRedstoneEvent(BlockRedstoneEvent event)andonPhysicsEvent(BlockPhysicsEvent event)fromBlockEventListener.javatoHighFreqBlockEventListener.java.Performance Comparison
high-frequency-listener=true
= default value; behavior as before
high-frequency-listener=false
= after deactivation of the high-frequency flags
Test circuit
http://redstoneworld.de/downloads/intern/plugins/laggy_adder.zip
Note: It should be noted that the "/tps" command from Spigot still needs some time after the server start for the value to level out, as it is rounded here.
Submitter Checklist