F200 initial support #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the functionality to check for camera type while connecting Refactored the init function Modified the data structure for enabling streams Removed looping for stream related functions Added a common function for setting streams Refactored functions to enable inheritance Renamed functions to reflect ROS terminologies Reordered the function definitions in their calling order Refactored the function to set static camera options Fixed coding standards Added pointcloud flag in test Automated test for camera options Updated comments Refactor of README file is pending
| gen = ParameterGenerator() | ||
|
|
||
| # Name Type Level Description Default Min Max | ||
| gen.add("enable_depth", bool_t, 0, "Enable Depth", True) |
There was a problem hiding this comment.
Did you try dynamic enable/disable color stream for F200? If its working, we should add that too.
|
My previous comments were addressed. Approved. 👍 |
|
Approved. |
a6a4a74 to
1b6011c
Compare
|
Thanks for your review comments. FYI, I have updated the README with the F200 related information. |
1b6011c to
2b80783
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue: #15 #65
Changes proposed in this pull request: