Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export dynamic_reconfigure to dependent packages #673

Merged

Conversation

efernandez
Copy link
Contributor

No description provided.

@doronhi
Copy link
Contributor

doronhi commented Mar 18, 2019

Could you please elaborate why this is needed? What is the use case?

@stwirth
Copy link
Contributor

stwirth commented Mar 18, 2019

Here's an explanation of what CATKIN_DEPENDS does: https://answers.ros.org/question/58498/what-is-the-purpose-of-catkin_depends/

ddynamic_reconfigure does not encapsulate dynamic_reconfigure entirely, #include <ddynamic_reconfigure/ddynamic_reconfigure.h> pulls in #include <dynamic_reconfigure/server.h>.
The CATKIN_DEPENDS tells packages that find_package(catkin COMPONENTS ddynamic_reconfigure) to pull include dirs and libraries from dynamic_reconfigure as well.

@doronhi doronhi merged commit 22c2c7b into IntelRealSense:development Mar 19, 2019
@efernandez efernandez deleted the export_dynamic_reconfigure branch March 19, 2019 13:58
@efernandez
Copy link
Contributor Author

@doronhi As @stwirth already said, we need this because ddynamic_reconfigure uses dynamic_reconfigure on its headers, so client libraries/pkgs require that dependency exported in order to build properly.

This is an issue if you do an isolated build.

Thanks for merging this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants