Prepare for Package Release #59
Conversation
| # Install config files | ||
| install(DIRECTORY config/ | ||
| DESTINATION ${CATKIN_PACKAGE_SHARE_DESTINATION}/config | ||
| ) |
There was a problem hiding this comment.
Do we need to install the package.xml too?
There was a problem hiding this comment.
The package.xml is automatically placed in the install directory by catkin.
|
Approved once all the exec_depends are identified and updated. |
Add installation steps for all files. Update package.xml to version 2. Updates to the maintainers and dependencies.
| <run_depend>rospy</run_depend> | ||
|
|
||
| <exec_depend>roslaunch</exec_depend> | ||
| <exec_depend>realsense_camera</exec_depend> |
There was a problem hiding this comment.
Correct me if I'm wrong, but I think we don't actually have a direct dependency on realsense_camera package. We have a dependency on turtlebot_bringup, and THAT will have a dependency on realsense_camera (because it launches the 3d sensor).
Otherwise this list looks accurate and complete.
There was a problem hiding this comment.
@kevincwells Considering we have the realsense_navigation package in the same repository and we know it will indirectly require the realsense_camera package, are you opposed to leaving that dependency?
There was a problem hiding this comment.
I'm fine with leaving it in.
I approve this request.
…ut-constants Refactored out constants to include from header file
Changes proposed in this pull request: