Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace stereo module with depth module #2688

Conversation

SamerKhshiboun
Copy link
Contributor

@SamerKhshiboun SamerKhshiboun commented Apr 11, 2023

Tracked by [DSO-18538]

Replace Info and Debug output including "Stereo Module" with "Depth Module"
Used "rs2_to_ros" function, which is in a common use inside our ROS wrapper, but was missing in some other places.

For example:

with new change, service sensor output includes depth_module instead of stereo_module

administrator@perclnx466 ~/ros2_humble $ ros2 service call /camera/device_info realsense2_camera_msgs/srv/DeviceInfo
requester: making request: realsense2_camera_msgs.srv.DeviceInfo_Request()

response:
realsense2_camera_msgs.srv.DeviceInfo_Response(device_name='intel_realsense_d435i', serial_number='912112073098', firmware_version='5.13.0.54', usb_type_descriptor='3.2', firmware_update_id='012345678901', sensors='depth_module,rgb_camera,motion_module', physical_port='/sys/devices/pci0000:00/0000:00:14.0/usb2/2-2/2-2:1.0/video4linux/video0')

also when launching / stopping the node, new changes are on (depth module instead of stereo module):

[realsense2_camera_node-1] [INFO] [1681232696.776424459] [camera.camera]: Stopping Sensor: Depth Module
[realsense2_camera_node-1] [INFO] [1681232696.800069233] [camera.camera]: Starting Sensor: Depth Module
[realsense2_camera_node-1] [INFO] [1681232696.854024481] [camera.camera]: Open profile: stream_type: Depth(0), Format: Z16, Width: 848, Height: 480, FPS: 30
[realsense2_camera_node-1] [INFO] [1681232767.603262833] [camera.camera]: Stop Sensor: Depth Module
[realsense2_camera_node-1] [INFO] [1681232767.603350548] [camera.camera]: Close Sensor.
[realsense2_camera_node-1] [INFO] [1681232767.614454247] [camera.camera]: Close Sensor - Done.

also when running with log_level:=debug, the changes are on (depth module instead of stereo module)

[realsense2_camera_node-1] [DEBUG] [1681233253.327902192] [camera.camera]: Set Depth Module as VideoSensor.
[realsense2_camera_node-1] [DEBUG] [1681233253.448831225] [camera.camera]: Depth Module:active_profiles.size() = 0
[realsense2_camera_node-1] [DEBUG] [1681233253.448852202] [camera.camera]: Depth Module:wanted_profiles

@SamerKhshiboun SamerKhshiboun marked this pull request as ready for review April 11, 2023 17:31
@SamerKhshiboun SamerKhshiboun requested a review from Nir-Az April 11, 2023 17:31
@SamerKhshiboun SamerKhshiboun self-assigned this Apr 11, 2023
Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@SamerKhshiboun need to notify Val team?

@Nir-Az Nir-Az merged commit a98615f into IntelRealSense:ros2-development Apr 12, 2023
@SamerKhshiboun SamerKhshiboun deleted the stero_module_to_depth_module branch May 9, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants