Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish real frame rate of realsense camera node topics/publishers #2408

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Publish real frame rate of realsense camera node topics/publishers #2408

merged 2 commits into from
Jul 14, 2022

Conversation

SamerKhshiboun
Copy link
Contributor

@SamerKhshiboun SamerKhshiboun commented Jul 12, 2022 •
edited by maloel
Loading

  • Catch backend exceptions and don't tick frequency diagnostics if so
  • Tick the frequency diagnostics only if topic publishes the frame

All changes in base_realsense_node are removing the try/catch and moving them outside to the ros_sensor file

Tracked on [LRS-434] and [LRS-448]

@SamerKhshiboun
Copy link
Contributor Author

all changes in base_realsense_node are removing the try/catch and moving them outside to the ros_sensor file

@Nir-Az Nir-Az self-requested a review July 13, 2022 08:22
Nir-Az
Nir-Az approved these changes Jul 13, 2022
View reviewed changes
Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maloel maloel merged commit be06827 into IntelRealSense:ros2-beta Jul 14, 2022
@SamerKhshiboun SamerKhshiboun deleted the this_one_fix_frequency_of_publishers branch January 3, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nir-Az Nir-Az Nir-Az approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamerKhshiboun @Nir-Az @maloel