Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tx,Ty not filled in CameraInfo for infra2 #427

Closed
pavloblindnology opened this issue Jul 25, 2018 · 3 comments · Fixed by #901
Closed

Tx,Ty not filled in CameraInfo for infra2 #427

pavloblindnology opened this issue Jul 25, 2018 · 3 comments · Fixed by #901

Comments

@pavloblindnology
Copy link
Contributor

According to the next line Tx, Ty is not filled for right image CameraInfo. As the result, baseline cannot be resolved in a standard ROS way.
https://github.com/intel-ros/realsense/blob/5210e673ec0d266c62590b433c8b568954f4fdfd/realsense2_camera/src/base_realsense_node.cpp#L828
@dorodnic
Copy link
Contributor

@doronhi seems like a bug on our side, right?

@RealSenseCustomerSupport
Copy link
Collaborator

[Please Ignore - RealSense system comment]

pavloblindnology added a commit to Blindnology/realsense that referenced this issue Aug 23, 2019
@pavloblindnology
Added filling correct Tx, Ty values in projection matrix of right
12a5062 
camera.
IntelRealSense#427
@pavloblindnology pavloblindnology mentioned this issue Aug 23, 2019
Merged
pavloblindnology added a commit to Blindnology/realsense that referenced this issue Nov 22, 2019
@pavloblindnology
Added filling correct Tx, Ty values in projection matrix of right
fecc64c 
camera.
IntelRealSense#427
pavloblindnology added a commit to Blindnology/realsense that referenced this issue Aug 5, 2020
@pavloblindnology
Added filling correct Tx, Ty values in projection matrix of right
0c690a7 
camera.
IntelRealSense#427
pavloblindnology added a commit to Blindnology/realsense that referenced this issue Aug 21, 2020
@pavloblindnology
Added filling correct Tx, Ty values in projection matrix of right
f435aca 
camera.
IntelRealSense#427

Conflicts:
	realsense2_camera/src/base_realsense_node.cpp
@doronhi
Copy link
Contributor

doronhi commented Nov 16, 2020

With #1242 now merged, I believe this issue can be closed.

pavloblindnology added a commit to Blindnology/realsense that referenced this issue Feb 5, 2021
@pavloblindnology
Added filling correct Tx, Ty values in projection matrix of right
603dead 
camera.
IntelRealSense#427
pavloblindnology added a commit to Blindnology/realsense that referenced this issue Mar 25, 2021
@pavloblindnology
Added filling correct Tx, Ty values in projection matrix of right
a15c1de 
camera.
IntelRealSense#427
pavloblindnology added a commit to Blindnology/realsense that referenced this issue Jan 18, 2022
@pavloblindnology
Added filling correct Tx, Ty values in projection matrix of right
1304525 
camera.
IntelRealSense#427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add filling correct Tx, Ty values in projection matrix of right camera. Blindnology/realsense
4 participants
@dorodnic @pavloblindnology @doronhi @RealSenseCustomerSupport