Fix colorizer - Get depth units from depth_sensor API. #7645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfo to support also l500.
|
JIRA? GitHub issue? |
ev-mp
reviewed
Oct 26, 2020
src/proc/colorizer.cpp
Outdated
| auto depth_sensor = As< librealsense::depth_sensor >( snr ); | ||
| if( depth_sensor ) | ||
| _depth_units = depth_sensor->get_depth_scale(); | ||
|
|
There was a problem hiding this comment.
Please add "Else" case with throw/error report
maloel
reviewed
Oct 27, 2020
src/proc/colorizer.cpp
Outdated
| } | ||
| else | ||
| { | ||
| LOG_ERROR( "Failed to query depth units from sensor." ); |
There was a problem hiding this comment.
Why do you guys keep putting in periods into log files? :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get depth units from depth_sensor API instead of disparity_info to support also l500.
#7089
Tracked on:RS5-8868