Community fixes #2790
Merged
Community fixes #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ev-mp
reviewed
Nov 28, 2018
| @@ -3468,7 +3468,7 @@ stbi_inline static int stbi__bit_reverse(int v, int bits) | |||
|
|
|||
| static int stbi__zbuild_huffman(stbi__zhuffman *z, stbi_uc *sizelist, int num) | |||
| { | |||
| int i,k=0; | |||
| int i,kl=0; | |||
There was a problem hiding this comment.
Should we notify the 3rd party in such case ?
ev-mp
reviewed
Nov 28, 2018
examples/CMakeLists.txt
Outdated
| @@ -8,6 +8,8 @@ set(CMAKE_EXPORT_COMPILE_COMMANDS 1) | |||
| # View the makefile commands during build | |||
| #set(CMAKE_VERBOSE_MAKEFILE on) | |||
|
|
|||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror=shadow") | |||
There was a problem hiding this comment.
Can it be moved to the core lib, for builds w/o demos, like pyrealsense ?
ev-mp
approved these changes
Nov 28, 2018
bfd6a3e to
f006ee9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2645 - symbols collision with ROS libraries
#2763 -
-WshadowwarningsBump version to 2.17