Pipeline callback api #2773
Merged
Pipeline callback api #2773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorodnic
reviewed
Nov 27, 2018
examples/callback/readme.md
Outdated
| stream_names[p.unique_id()] = p.stream_name(); | ||
| ``` | ||
|
|
||
| Periodically print the frame counters. |
There was a problem hiding this comment.
I think this require a bit more explanation
examples/callback/readme.md
Outdated
|
|
||
| ## Overview | ||
|
|
||
| This sample demonstrates how to configure the camera for streaming frames using the pipeline's callback API. |
There was a problem hiding this comment.
This part has to be considerably expanded -
We need to explain why the user would want to consider callback and what the example is trying to demonstrate.
examples/callback/readme.md
Outdated
| #include <librealsense2/rs.hpp> // Include RealSense Cross Platform API | ||
| ``` | ||
|
|
||
| Define frame counters |
There was a problem hiding this comment.
Maybe more explanation about the state and how it is going to be used
| // Therefore any modification to common memory should be done under lock | ||
| auto callback = [&](const rs2::frame& frame) | ||
| { | ||
| std::lock_guard<std::mutex> lock(mutex); |
examples/cmake/readme.md
Outdated
| project(hello_librealsense2) | ||
| ``` | ||
|
|
||
| Find librealsense installation, librealsense currently not implemented for Windows |
There was a problem hiding this comment.
librealsense currently not implemented for Windows - this doesn't sound right
dorodnic
approved these changes
Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pipeline callback (async) API
Code snippet
rs2::pipeline pipe;
pipe.start([](const rs2::frame& f)
{
// handle frame
});
Jira:
DSO-10774 - gyro and accel aren't a default in motion module
DSO-10943 - D435i should work properly with all SDK examples