Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM NEON intrinsics to pointcloud #13396

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

fateshelled
Copy link

Changes:

  • adding pointcloud_neon class
    • neon-pointcloud.cpp is based on the code in sse-pointcloud.cpp
    • tested on Ubuntu 22.04, OrangePi5 (RK3588s, 8GB of RAM) and RealSense D435.

I optimized pointcloud processing for ARM CPUs.
Please review it.

@sysrsbuild
Copy link
Collaborator

Can one of the admins verify this patch?

@fateshelled fateshelled changed the title NEON support pointcloud Add ARM NEON intrinsics to pointcloud Oct 3, 2024
@@ -0,0 +1,242 @@
// License: Apache 2.0. See LICENSE file in root directory.
// Copyright(c) 2017 Intel Corporation. All Rights Reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024 please

@Nir-Az
Copy link
Collaborator

Nir-Az commented Oct 13, 2024

@fateshelled thanks! Looks good..
Did you verify it works on the specific HW?
I will run some internal CI's in parallel to check for regressions..

@Nir-Az Nir-Az merged commit ed6fc83 into IntelRealSense:development Oct 13, 2024
19 checks passed
@fateshelled
Copy link
Author

Thank you for merging.
I checked that the point cloud looks correct in realsense-viewer. However, not verified that the values are consistent with other pointcloud classes.
Hardware used was Realsense D435 and OrangePi5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants