Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 98f3b05df to see if sources are visible on coveralls.io #1439

Closed
wants to merge 1 commit into from

Conversation

diptorupd
Copy link
Contributor

@diptorupd diptorupd commented Apr 17, 2024

  • Have you provided a meaningful PR description?
    Reverts 98f3b05 Coveralls.io does not display the sources for numba-dpex anymore. The PR triages if the problem is due to the official coveralls workflow.

Although not showing sources is a feature and not a bug (lemurheavy/coveralls-public#1579), the sources are displayed for dpctl and dpnp. So, let us see what happens if we go back to what was there before.

  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@diptorupd diptorupd force-pushed the fix/coveralls-source-display branch from 91f72a4 to c10388f Compare April 17, 2024 20:53
@coveralls
Copy link
Collaborator

coveralls commented Apr 17, 2024

Coverage Status

coverage: 84.542% (-2.5%) from 87.08%
when pulling 2c607bf on fix/coveralls-source-display
into e625c9d on main.

@diptorupd
Copy link
Contributor Author

diptorupd commented Apr 17, 2024

@ZzEeKkAa Want your thoughts on this PR. The issue is after switching to official coveralls action, coveralls.io does not show any source files. Reverting the change does show the sources.

@diptorupd diptorupd force-pushed the fix/coveralls-source-display branch from c10388f to 2c607bf Compare April 19, 2024 02:35
@ZzEeKkAa ZzEeKkAa mentioned this pull request Apr 30, 2024
5 tasks
@diptorupd diptorupd deleted the fix/coveralls-source-display branch May 28, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants