-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overloads for new atomic_ref and fetch_phi API to numba_dpex.experimental module #1198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diptorupd
force-pushed
the
redesign/atomics_op_v3
branch
10 times, most recently
from
November 3, 2023 05:00
be5df8a
to
d19969a
Compare
diptorupd
force-pushed
the
redesign/atomics_op_v3
branch
4 times, most recently
from
November 6, 2023 19:03
f88eafc
to
54ba2ea
Compare
diptorupd
changed the title
Add overloads for new atomic and barrier API to numba_dpex.experimental module
Add overloads for new atomic_ref and fetch_phi API to numba_dpex.experimental module
Nov 8, 2023
diptorupd
force-pushed
the
redesign/atomics_op_v3
branch
12 times, most recently
from
November 14, 2023 21:57
f3a9550
to
ccb830f
Compare
- The experimental target is now fully separated from the DpexKernelTarget with a differnet string and device class. - Overloads are now added by KernelDispatcher into current target as user functions.
- All overloads are now added to the experimental target. - The inline keyword is no longer set to "always" for the atomic_ref overloads.
diptorupd
force-pushed
the
redesign/atomics_op_v3
branch
from
November 16, 2023 04:28
a316b23
to
1c240e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR introduces new API functions to numba_dpex.kernel decorated functions using Numba high-level extending API (
overload
). The feature is going to be added to the numba_dpex.experimental module till it is ready for everyday use. Eventually, the new API will replace the numba_dpex.ocl module.