Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload wheel to the same version #1167

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Upload wheel to the same version #1167

merged 1 commit into from
Oct 12, 2023

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Oct 12, 2023

Wheels are uploaded to the version from wheels package that comes from versioner. That version is different for wheel and Conda and contains GitHub stash. That results into junk in Conda registry version list. PR simply uploads same wheel to the version of Conda package.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this Oct 12, 2023
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd as a code owner October 12, 2023 17:16
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Similar change to this was already merged in dpctl: IntelPython/dpctl#1435 and main trunk build is clean.

@diptorupd diptorupd enabled auto-merge October 12, 2023 19:14
@diptorupd diptorupd merged commit cf7b9f4 into main Oct 12, 2023
@diptorupd diptorupd deleted the fix/wheel_upload branch October 12, 2023 19:14
github-actions bot added a commit that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants