Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ninja #1124

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Use ninja #1124

merged 1 commit into from
Nov 7, 2023

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Aug 30, 2023 •
edited
Loading

Ninja is a faster generator, and compare to default generators works out of box with sycl.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa force-pushed the feature/use_ninja branch 6 times, most recently from 45560c2 to 557d6b6 Compare August 30, 2023 19:48
@ZzEeKkAa ZzEeKkAa force-pushed the feature/use_ninja branch 2 times, most recently from dc386e0 to 337b9e3 Compare September 12, 2023 19:59
@ZzEeKkAa ZzEeKkAa self-assigned this Sep 12, 2023
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review September 12, 2023 20:53
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd as a code owner September 12, 2023 20:53
@ZzEeKkAa ZzEeKkAa requested a review from chudur-budur November 7, 2023 19:33
@ZzEeKkAa ZzEeKkAa enabled auto-merge November 7, 2023 19:42
chudur-budur
chudur-budur approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@chudur-budur chudur-budur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@ZzEeKkAa please merge once the PR passes on all CI runs.

@ZzEeKkAa ZzEeKkAa merged commit fe619d0 into main Nov 7, 2023
10 checks passed
@ZzEeKkAa ZzEeKkAa deleted the feature/use_ninja branch November 7, 2023 19:43
github-actions bot added a commit that referenced this pull request Nov 7, 2023
@github-actions
Merge pull request #1124 from IntelPython/feature/use_ninja
65869f8 
Use ninja fe619d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chudur-budur chudur-budur chudur-budur approved these changes

@diptorupd diptorupd Awaiting requested review from diptorupd

Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZzEeKkAa @chudur-budur