Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utils for config instantiation. #250

Merged
merged 7 commits into from
May 16, 2024
Merged

Conversation

mzweilin
Copy link
Contributor

@mzweilin mzweilin commented May 2, 2024

What does this PR do?

This PR add utils to instantiate from config files generated by python -m mart.generate_config.

(It should be better if we can get rid of the intermediate config files in the future.)

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • pytest
  • CUDA_VISIBLE_DEVICES=0 python -m mart experiment=CIFAR10_CNN_Adv trainer=gpu trainer.precision=16 reports 70% (21 sec/epoch).
  • CUDA_VISIBLE_DEVICES=0,1 python -m mart experiment=CIFAR10_CNN_Adv trainer=ddp trainer.precision=16 trainer.devices=2 model.optimizer.lr=0.2 trainer.max_steps=2925 datamodule.ims_per_batch=256 datamodule.world_size=2 reports 70% (14 sec/epoch).

Before submitting

  • The title is self-explanatory and the description concisely explains the PR
  • My PR does only one thing, instead of bundling different changes together
  • I list all the breaking changes introduced by this pull request
  • I have commented my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run pre-commit hooks with pre-commit run -a command without errors

Did you have fun?

Make sure you had fun coding 🙃

Base automatically changed from mzweilin/prepare_model to main May 14, 2024 23:22
@mzweilin mzweilin requested a review from dxoigmn May 15, 2024 16:32
Copy link
Contributor

@dxoigmn dxoigmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a lightning Callback?

@mzweilin
Copy link
Contributor Author

Why is this a lightning Callback?

Anomalib performs type checking when instantiate our Callback, so I have to make it a Callback explicitly. We also have the generic instantiate function/class that can instantiate any object.

@mzweilin mzweilin requested a review from dxoigmn May 15, 2024 19:21
@mzweilin mzweilin merged commit 07409b4 into main May 16, 2024
5 checks passed
@mzweilin mzweilin deleted the mzweilin/instantiate_config branch May 16, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants