Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: DO NOT MERGE: ENH: Handle IPP/IOP/PixelSpacing for SC #4120

Closed
wants to merge 1 commit into from
Closed

WIP: DO NOT MERGE: ENH: Handle IPP/IOP/PixelSpacing for SC #4120

wants to merge 1 commit into from

Conversation

issakomi
Copy link
Member

@issakomi issakomi commented Jul 20, 2023 •
edited
Loading

The PR is to run tests with changes in the upstream PR malaterre/GDCM#158

Closes #4109

Replaces #4111

@github-actions github-actions bot added the area:ThirdParty Issues affecting the ThirdParty module label Jul 20, 2023
@jcfr jcfr mentioned this pull request Jul 20, 2023
Closed
@jcfr
Copy link
Contributor

jcfr commented Jul 20, 2023

Thanks for working on this 💯

If possible, I suggest to include the following trailer in the commit:

Co-authored-by: Steve Pieper <pieper@isomics.com>

Thanks for considering 🙏

@issakomi
Copy link
Member Author

If possible, I suggest to include the following trailer in the commit:

Co-authored-by: Steve Pieper <pieper@isomics.com>

I have added Co-authored-by to the upstream PR malaterre/GDCM#158
I am not sure that the PR will be accepted by GDCM, s. post.
This one was just to run the tests.
CC @pieper

Screenshot 2023-07-20 at 17-06-37 ENH Handle IPP_IOP_PixelSpacing for SC by issakomi · Pull Request #158 · malaterre_GDCM

@jcfr
Copy link
Contributor

jcfr commented Jul 20, 2023

I have added Co-authored-by to the upstream PR

Outstanding. 🙏

not sure that the PR will be accepted by GDCM

🤞

@pieper
Copy link
Contributor

pieper commented Jul 20, 2023

Thank you @issakomi - this looks like a much more complete solution.

@issakomi
Copy link
Member Author

S. malaterre/GDCM#158

@issakomi issakomi closed this Jul 26, 2023
@issakomi issakomi deleted the test_sc branch May 5, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area:ThirdParty Issues affecting the ThirdParty module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GDCM ignores image geometry in secondary captures
3 participants
@issakomi @jcfr @pieper