fix(runPipelineNode): unmounting overlapping paths #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If multiple paths are mounted such that one is a parent of the
other, then you may encounter the following exceptions:
```
Rejected promise returned by test. Reason:
ErrnoError {
code: 'EINVAL',
errno: 28,
message: 'Invalid argument',
}
Rejected promise returned by test. Reason:
ErrnoError {
code: 'ENOENT',
errno: 44,
message: 'No such file or directory',
}
```
This fix will determine paths that are safely unmountable,
and only unmount each path once.
065e403 to
566bff2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If multiple paths are mounted such that one is a parent of the other, then you may encounter the following exceptions:
This fix will determine paths that are safely unmountable, and only unmount each path once.