feat(compare-images): add spatial tolerance #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadh4v
commented
Jul 18, 2024
jadh4v
commented
Jul 18, 2024
jadh4v
commented
Jul 18, 2024
25058e1 to
9d86b78
Compare
thewtex
reviewed
Jul 18, 2024
| @@ -12,6 +12,7 @@ def compare_double_images( | |||
| test_image: Image, | |||
| baseline_images: List[Image] = [], | |||
| difference_threshold: float = 0, | |||
| spatial_tolerance: float = 1e-06, | |||
| @@ -12,6 +12,7 @@ async def compare_double_images_async( | |||
| test_image: Image, | |||
| baseline_images: List[Image] = [], | |||
| difference_threshold: float = 0, | |||
| spatial_tolerance: float = 1e-06, | |||
There was a problem hiding this comment.
also missed out on updating the wasm binary
Add an option to pass spatial tolerance when comparing image direction matrix and origin for spatial overlap. Also export `toScalarDouble` js function for external use.
9d86b78 to
75f2db4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to pass spatial tolerance when comparing image direction matrix and origin for spatial overlap.
Also export
toScalarDoublejs function for external use.