Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loadPipelineModule): load pipeline once #1034

Merged
merged 1 commit into from
Jan 3, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(loadPipelineModule): load only once
  • Loading branch information
floryst authored Jan 2, 2024
commit 4784004d29edfd188f86ec33b13c02002c77f887
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import loadEmscriptenModule from '../internal/load-emscripten-module-web-worker.js'
import PipelineEmscriptenModule from '../pipeline-emscripten-module.js'

// To cache loaded pipeline modules
const pipelineToModule: Map<string, PipelineEmscriptenModule> = new Map()
// To cache loaded pipeline modules wrapped in a Promise
const pipelineToModule: Map<string, Promise<PipelineEmscriptenModule>> = new Map()

async function loadPipelineModule (pipelinePath: string | object, baseUrl: string): Promise<PipelineEmscriptenModule> {
let moduleRelativePathOrURL: string | URL = pipelinePath as string
Expand All @@ -13,10 +13,10 @@ async function loadPipelineModule (pipelinePath: string | object, baseUrl: strin
pipeline = moduleRelativePathOrURL.href
}
if (pipelineToModule.has(pipeline)) {
pipelineModule = pipelineToModule.get(pipeline) as PipelineEmscriptenModule
pipelineModule = await pipelineToModule.get(pipeline) as PipelineEmscriptenModule
} else {
pipelineToModule.set(pipeline, await loadEmscriptenModule(moduleRelativePathOrURL, baseUrl) as PipelineEmscriptenModule)
pipelineModule = pipelineToModule.get(pipeline) as PipelineEmscriptenModule
pipelineToModule.set(pipeline, loadEmscriptenModule(moduleRelativePathOrURL, baseUrl) as Promise<PipelineEmscriptenModule>)
pipelineModule = await pipelineToModule.get(pipeline) as PipelineEmscriptenModule
}
return pipelineModule
}
Expand Down
Loading