Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing release fields to UserListensMBIDMapping #44

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

RustyNova016
Copy link
Contributor

Those fields are missing in the model structs.

@InputUsername
Copy link
Owner

Thanks @RustyNova016!

@shymega LGTM, feel free to merge.

@InputUsername InputUsername requested review from InputUsername and removed request for shymega January 24, 2025 21:02
@InputUsername InputUsername merged commit 3962c00 into InputUsername:main Jan 24, 2025
3 checks passed
@InputUsername
Copy link
Owner

Thanks @RustyNova016!

@InputUsername InputUsername added this to the v0.8.2 milestone Jan 24, 2025
@shymega
Copy link
Collaborator

shymega commented Jan 24, 2025

Sorry - my GitHub notifications page is reaching around 4 pages now, and possibly more - perhaps we could look into Mergify, or auto-merge queues, so we can approve a PR, and merge it once CI passes?

@InputUsername
Copy link
Owner

Sorry - my GitHub notifications page is reaching around 4 pages now, and possibly more - perhaps we could look into Mergify, or auto-merge queues, so we can approve a PR, and merge it once CI passes?

No worries, this one is on me actually. For some reason I assumed I had reviewed and needed your approval as well, but apparently PRs only need one approval. In the future I'll just merge smaller PRs myself (and feel free to do so yourself as well).

Never heard of Mergify so I'll look into that. I believe auto-merge queues are only available for repos under an organization or for Enterprise users. But honestly not sure if it's worth it in the first place, we don't get that many PRs.

@RustyNova016
Copy link
Contributor Author

Mergify, or auto-merge queues, so we can approve a PR, and merge it once CI passes?

GitHub has a native way to do that.
You need to allow auto merge on the repo's settings, and it will automerge when CI pass, allongside branch protections

@shymega
Copy link
Collaborator

shymega commented Feb 7, 2025

Yeah, that works too. We should definitely look into it - could even automate releases, but I'm not sure how comfortable I am with that.

@InputUsername Should I open a tracking issue for auto-merge queues?

@InputUsername
Copy link
Owner

@shymega I've enabled auto-merge, that should be enough right? I don't think we need more advanced functionality given the (relatively) low volume of PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants