-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing release fields to UserListensMBIDMapping
#44
fix: add missing release fields to UserListensMBIDMapping
#44
Conversation
1f74fa6
to
8f4bcfb
Compare
Thanks @RustyNova016! @shymega LGTM, feel free to merge. |
Thanks @RustyNova016! |
Sorry - my GitHub notifications page is reaching around 4 pages now, and possibly more - perhaps we could look into Mergify, or auto-merge queues, so we can approve a PR, and merge it once CI passes? |
No worries, this one is on me actually. For some reason I assumed I had reviewed and needed your approval as well, but apparently PRs only need one approval. In the future I'll just merge smaller PRs myself (and feel free to do so yourself as well). Never heard of Mergify so I'll look into that. I believe auto-merge queues are only available for repos under an organization or for Enterprise users. But honestly not sure if it's worth it in the first place, we don't get that many PRs. |
GitHub has a native way to do that. |
Yeah, that works too. We should definitely look into it - could even automate releases, but I'm not sure how comfortable I am with that. @InputUsername Should I open a tracking issue for auto-merge queues? |
@shymega I've enabled auto-merge, that should be enough right? I don't think we need more advanced functionality given the (relatively) low volume of PRs. |
Those fields are missing in the model structs.