Improve CI workflows #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
InputUsername
commented
Jul 28, 2024
•
- Update CI workflow to checkout@v4
- Add workflow to check formatting
- Add workflow to verify MSRV (fixes Properly handle minimum supported Rust version (MSRV) #28)
shymega
requested changes
Jul 28, 2024
InputUsername
commented
Jul 29, 2024
| @@ -11,7 +11,7 @@ description = "ListenBrainz API bindings for Rust" | |||
| keywords = ["listenbrainz", "api", "bindings"] | |||
| categories = ["api-bindings"] | |||
| publish = true | |||
| rust-version = "1.58" | |||
| rust-version = "1.63.0" | |||
There was a problem hiding this comment.
For some reason cargo-msrv on my machine claims the MSRV is 1.58, but the workflow claims 1.63.0. Not sure why this is happening.
There was a problem hiding this comment.
Is cargo-msrv up to date, as well as your Rsut toolchian? What does rustc -V report in the project dir?
There was a problem hiding this comment.
Yep. I updated Rust and cargo-msrv and ran it, and it spit out 1.58.1. However, for some reason now it's claiming 1.63.0, so I guess I may have had a stale build cache or something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.