-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update response schemas to match the latest API version #13
Conversation
@InputUsername I'll review this tomorrow evening after I get back from my job interview. |
@shymega perfect, thanks! And best of luck with your job interview 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@InputUsername This all looks fine to me, I think we should make it clear in bold that it's a breaking change release, given a fair amount of return types have been modified, but other than that, excellent! 💯
Thanks! It went great, last time it didn't go so well (virtual, and it was mostly my fault), but this time they said my professionalism, body language, and questions/answers were vastly improved, so fingers crossed! |
Thanks! It definitely makes sense to indicate the breakage more clearly (even though it's not technically required), so I've added a note to the changelog.
That's great, hoping for the best 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, much better to present it as a breaking change.
ListenBrainz silently changed their response schemas, this PR addresses those changes (as reported in #12).
user/{user_name}/playing-now
:UserPlayingNowPayload::playing_now
;UserPlayingNowListen::playing_now
;user/{user_name}/listens
:UserListensListen::inserted_at
fromString
toi64
.stats/sitewide/artists
:StatsSitewideArtistsPayload::time_ranges
;StatsSitewideArtistsPayload::artists
;StatsSitewideArtistsTimeRange
;StatsSitewideArtistsArtist::artist_msid
.stats/user/{user_name}/artist-map
:Client::stats_user_artist_map
fromResult<StatsUserArtistMapResponse, Error>
to
Result<Option<StatsUserArtistMapResponse>, Error>
.users/{user_list}/recent-listens
:Client::users_recent_listens
;UsersRecentListensResponse
;UsersRecentListensPayload
;UsersRecentListensListen
;UsersRecentListensTrackMetadata
;examples/users_recent_listens.rs
.