merry holidays to those who celebrate #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Speykious
requested changes
Dec 24, 2023
|
hmm wgpu definitely both builds and works fine for me, not sure what could be wrong there. wasm32 target might not work fully as it's painful to test, so my only test for that is whether it compiles |
winit explicitly needs the `rwh_05` feature if we have to use `raw-window-handle` v0.5.
|
The |
|
Speykious
reviewed
Dec 24, 2023
Speykious
approved these changes
Dec 24, 2023
|
Merry Christmas :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently had to fix the same thing with another wgpu/winit thing so I figured might as well do this too