added the Happy Recovery Story page #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
good work but in the issue comments i mentioned that it will be added in landing page which is not ready , so do one thing just create a separate route for this no need to add any tab in the nav bar in the exisiting ui |
|
Hello @codewarnab, I'm sorry for my mistake. I have removed the tab from the navbar, and the path to the page is /recovereds-page Please review once again |
|
@codewarnab please review |
codewarnab
requested changes
Jul 9, 2024
src/Components/shared/Navbar.jsx
Outdated
| />, | ||
| <BottomNavigationAction key="register" value="/register" showLabel label="Register" component={Link} to="/register" icon={<FaUserPlus size={28} />} />, | ||
| <BottomNavigationAction key="login" value="/login" showLabel label="Login" component={Link} to="/login" icon={<FaUser size={24} />} />, | ||
| /*<BottomNavigationAction key="RecoveredsPage" value="/recovereds-page" showLabel label="Stories" component={Link} to="/recovereds-page" icon={<FaPaw size={28} />} />, // for recovered stories section*/ |
src/Components/shared/Navbar.jsx
Outdated
| @@ -2,14 +2,12 @@ import React, { useState, useEffect } from 'react'; | |||
| import { Link, useLocation } from 'react-router-dom'; | |||
| import BottomNavigation from '@mui/material/BottomNavigation'; | |||
| import BottomNavigationAction from '@mui/material/BottomNavigationAction'; | |||
| import { FaUser, FaUserPlus} from 'react-icons/fa'; | |||
| import { FaUser, FaUserPlus, FaPaw } from 'react-icons/fa'; | |||
src/Components/shared/Navbar.jsx
Outdated
There was a problem hiding this comment.
if possible revert this file as before
|
I have done changes and added the current original code of navbar to Navbar.jsx, please check @codewarnab |
codewarnab
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As stated in the issue #495 I have added a page that showcases the rescuers and the recovery stories of the rescued animals
Related Issue
[Cite any related issue(s) this pull request addresses. If none, simply state "None"]
Screenshots / GIFs (if applicable)
paws.mp4
Checklist:
Additional Notes
I have made the folder under src / pages / user / RecoveredsPage
The required images are added in the images folder of the RecoveredsPage folder.
Please review the PR, and if there are any changes required, let me know