-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#279 contact information page made responsive #334
Conversation
Hi, please make the size of both buttons same, otherwise good work, itll be merged after that, also is it responsive on desktop? |
@Riddhi162 add screenshot for desktop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Riddhi162 please update your branch and attach a screenshot of desktop
I also made the button size same |
I edited the files here only and made the button size similar.Please check the commits. |
I think if you if you increase the width to 60% of the width of the div it will looks good and some increase in height in desktop also and font size in the input filed+placeholder please try this and show us how it's looking |
Also make the buttons bigger and add space between them in desktop |
whose wiidth should i make to 60% the input field or its outer div? |
no leave it just make the buttons bigger and add space between them for desktop and solve the conflicts |
Done. |
can you please add another screenshot how its looking now for mobile and desktop |
thank you good job will be merged soon |
Description
[Please include a brief description of the changes or features added]
I have made the contact details page completely responsive.For all the screens it is responsive.
Related Issue
#279
Screenshots / GIFs (if applicable)
[Attach any relevant screenshots or GIFs demonstrating the changes]
![Screenshot 2024-05-15 020112](https://private-user-images.githubusercontent.com/135015856/330673117-17d3c2a5-4dd0-42f1-a602-4639615ce4b9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NTE2MDYsIm5iZiI6MTczOTQ1MTMwNiwicGF0aCI6Ii8xMzUwMTU4NTYvMzMwNjczMTE3LTE3ZDNjMmE1LTRkZDAtNDJmMS1hNjAyLTQ2Mzk2MTVjZTRiOS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QxMjU1MDZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xOGQxNDYzZjc0MTJiN2QyZDAzNWEzOTI3NzQwMjk4ZGU0MzA3NDNiNzQyMWU2ODU3NmUxYTIxOTM2Zjg4N2Q2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.wJnVX3LgByMA--wSnLapEgd0d-NrvOWWQwup7OyiDhU)
![Screenshot 2024-05-14 234249](https://private-user-images.githubusercontent.com/135015856/330673184-b16debe9-d11b-4429-bdfb-42e6f2ed2edf.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NTE2MDYsIm5iZiI6MTczOTQ1MTMwNiwicGF0aCI6Ii8xMzUwMTU4NTYvMzMwNjczMTg0LWIxNmRlYmU5LWQxMWItNDQyOS1iZGZiLTQyZTZmMmVkMmVkZi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QxMjU1MDZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mZWEwZDZlNzUxYWEzNmVkODY1NTNmYjU0ZDYzNDU1MDUxOTRjZWRjMWRjNTEzNzJhZWRhMzhiZDA1OTE0NGEwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9._2-_YYvUh9F5yJRSNdjevUJhR5bz51DDb2k07sh-uoQ)
BEFORE:
AFTER:
Checklist:
Additional Notes
[Add any additional notes or context about the changes made]