-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement chunk save/load #3
base: Network
Are you sure you want to change the base?
Conversation
@harrynull only one question. Does it work properly or is this just a procedural practice? |
And please consider async IO API as we are dealing with protentially tens of megabytes of data per second and it is not a good idea to jam the worker thread for this |
It's totally untested as the game was crashing at the time I implemented it. |
@harrynull Yes, they are multi-threaded, but the implementation does not take system calls into account, so it will block the execution thread. There is no good cross-platform solution for this, so better do it explicitly. |
Untested
Do not merge.