Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow % char in DID #34

Closed
domwoe opened this issue Jun 2, 2021 · 1 comment · Fixed by #39
Closed

Allow % char in DID #34

domwoe opened this issue Jun 2, 2021 · 1 comment · Fixed by #39

Comments

@domwoe
Copy link

domwoe commented Jun 2, 2021

I wanted to add support for url encoded port numbers in the did:web resolver and use pyDID for DID validation.
pyDID does currently not allow the % char in the method specific id.
The DID core spec has been updated to allow % char. See w3c/did#703
@domwoe domwoe mentioned this issue Jun 2, 2021
Merged
dbluhm added a commit that referenced this issue Jun 4, 2021
@dbluhm
feat: allow % char in DID
d102694 
Fixes #34

Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
@dbluhm dbluhm mentioned this issue Jun 4, 2021
Merged
@dbluhm
Copy link
Member

dbluhm commented Jun 4, 2021

Implemented and released in 0.2.6

@dbluhm dbluhm closed this as completed Jun 4, 2021
dbluhm added a commit that referenced this issue Jun 4, 2021
@dbluhm
feat: allow % char in DID
acb656f 
Fixes #34

Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
@dbluhm dbluhm mentioned this issue Jun 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow % char in DID Indicio-tech/pydid
2 participants
@domwoe @dbluhm