fix: remove incorrect require check for sellEthForTokenToUniswapV3

IndexCoop · May 27, 2021 · 7f8048d · 7f8048d
1 parent ea59a2e
commit 7f8048d
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 20 deletions.
diff --git a/contracts/protocol/integration/exchange/ZeroExApiAdapter.sol b/contracts/protocol/integration/exchange/ZeroExApiAdapter.sol
@@ -181,9 +181,7 @@ contract ZeroExApiAdapter {
                 (encodedPath, minOutputTokenAmount, recipient) =
                     abi.decode(_data[4:], (bytes,  uint256, address));
                 supportsRecipient = true;
-                address _decodedInputToken;
-                (_decodedInputToken, outputToken) = _decodeTokensFromUniswapV3EncodedPath(encodedPath);
-                require(_decodedInputToken == ETH_ADDRESS, "sellEthForToken requires ETH input token");
+                (, outputToken) = _decodeTokensFromUniswapV3EncodedPath(encodedPath);
                 inputToken = ETH_ADDRESS;
             } else {
                 revert("Unsupported 0xAPI function selector");

diff --git a/test/protocol/integration/exchange/zeroExApiAdapter.spec.ts b/test/protocol/integration/exchange/zeroExApiAdapter.spec.ts
@@ -955,23 +955,6 @@ describe("ZeroExApiAdapter", () => {
         });
       }
 
-      it("rejects non ETH input token", async () => {
-        const data = zeroExMock.interface.encodeFunctionData("sellEthForTokenToUniswapV3", [
-          encodePath([otherToken, destToken]),
-          minDestinationQuantity,
-          destination,
-        ]);
-        const tx = zeroExApiAdapter.getTradeCalldata(
-          ETH_ADDRESS,
-          destToken,
-          destination,
-          sourceQuantity,
-          minDestinationQuantity,
-          data,
-        );
-        await expect(tx).to.be.revertedWith("sellEthForToken requires ETH input token");
-      });
-
       it("rejects wrong input token", async () => {
         const data = zeroExMock.interface.encodeFunctionData("sellEthForTokenToUniswapV3", [
           encodePath([ETH_ADDRESS, destToken]),