License is MIT #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that this change is possible after we change license to Impresscms otherwise we will have some legal issues with this. |
|
There was a LOT of pushback when we first tried even just altering the headers in files without changing the license. |
|
@skenow that was because we restructured files that were originally coming from Xoops. This is stuff we started by ourselves, so I don't see why we cannot license the composer installer as MIT. |
|
@fiammybe problem right now that we somehow need to access impresscms constants from this library - how to do that not including all ImpressCMS and also same license I don't know :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License file has license for GPLv2 but composer.json said that we use MIT.
Because MIT for using free components in commercial products, I decided that MIT would be better for us for that.
Do, you agree? :)