Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dotenv and env libs from dependencies #29

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Remove dotenv and env libs from dependencies #29

merged 1 commit into from
Jan 2, 2023

Conversation

MekDrop
Copy link
Member

@MekDrop MekDrop commented Jan 1, 2023

Because they áre not used in this plugin anymore.

@MekDrop MekDrop added the bug label Jan 1, 2023
@MekDrop MekDrop requested review from skenow and fiammybe January 1, 2023 21:37
fiammybe
fiammybe approved these changes Jan 2, 2023
View reviewed changes
Copy link
Member

@fiammybe fiammybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always good to reduce the number of dependencies

@fiammybe fiammybe merged commit f6fa037 into ImpressCMS:master Jan 2, 2023
@MekDrop MekDrop deleted the fix/remove-not-needed-dependencies-anymore branch January 2, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiammybe fiammybe fiammybe approved these changes

@skenow skenow Awaiting requested review from skenow

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MekDrop @fiammybe