Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a simple path to load data and explain to user to use their own #45

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Use a simple path to load data and explain to user to use their own #45

merged 1 commit into from
Dec 7, 2023

Conversation

dalonsoa
Copy link
Collaborator

@dalonsoa dalonsoa commented Dec 1, 2023

In summary, I've removed the problematic line and instead tell the user to choose the right path for their case.

Close #30

@dalonsoa dalonsoa requested review from TinyMarsh and tg2414 December 1, 2023 13:58
TinyMarsh
TinyMarsh approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@TinyMarsh TinyMarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a sensible solution to me.

@dalonsoa dalonsoa merged commit 052f7f7 into main Dec 7, 2023
21 checks passed
@dalonsoa dalonsoa deleted the docs branch December 7, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TinyMarsh TinyMarsh TinyMarsh approved these changes

@tg2414 tg2414 Awaiting requested review from tg2414

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation fails to build properly
2 participants
@dalonsoa @TinyMarsh