Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make deprecation as warnings for rivers #119

Merged
merged 2 commits into from
Oct 25, 2024
Merged

make deprecation as warnings for rivers #119

merged 2 commits into from
Oct 25, 2024

Conversation

barneydobson
Copy link
Collaborator

There are depth and capacity parameters in nearly all of our WSIMOD models. I think rather than having to remove all these entries can we just make these deprecation notices as warnings?

dalonsoa
dalonsoa approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! IT will be satisfying when, in a future version, you get rid of the deprecated features and you get rid of a lot of code.

@barneydobson barneydobson merged commit ddd25b1 into main Oct 25, 2024
20 checks passed
@barneydobson
Copy link
Collaborator Author

one day this will happen... maybe

@barneydobson barneydobson deleted the river-deprecation branch October 25, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalonsoa dalonsoa dalonsoa approved these changes

@liuly12 liuly12 Awaiting requested review from liuly12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barneydobson @dalonsoa