Add read_metadata() function
#26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It could be useful outside the submodule.
This is essentially a small wrapper to read_header, which just returns the metadata from the specified file. Closes ImperialCollegeLondon#25.
|
It looks like #24 needs to be merged first. |
Codecov Report
@@ Coverage Diff @@
## develop #26 +/- ##
===========================================
+ Coverage 92.24% 92.36% +0.11%
===========================================
Files 3 3
Lines 129 131 +2
===========================================
+ Hits 119 121 +2
Misses 10 10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dalonsoa
reviewed
Jan 24, 2023
|
I think it is useful as a convenience function, though that's obviously a bit subjective! I've added a test now. |
dalonsoa
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25.
It would be handy to be able to read just the metadata from a data file without having to load everything else. I've added a new
read_metadata()function to do this.