Validate user header #167
Merged
Validate user header #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdewar
approved these changes
Dec 18, 2024
csvy/validators.py
Outdated
| if key in VALIDATORS_REGISTRY: | ||
| if not isinstance(value_, dict): |
There was a problem hiding this comment.
Thinking about this, I suppose any Mapping type would work, not just dicts. The same is true for the input argument.
That said, users probably aren't going to be using other types of Mapping here all that often.
There was a problem hiding this comment.
And would TypeError maybe be more appropriate than ValueError?
There was a problem hiding this comment.
Yes to the second - I'll update. About the first, anything that can be unpacked with ** would work. I was not sure if Mappings in general allow this, so I sticked to dict that I know will work and, as you say, it is what most people will use.
There was a problem hiding this comment.
Changed in 08e187c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the
validate_readandvalidate_writewithvalidate_headerandheader_to_dict, respectively.validate_headeris used in just after reading) and just before writing operations to ensure that the header always complies with any registered validator.header_to_dictis run just before a write operation aftervalidate_headerto ensure that the header is serializable.A couple of extra checks have been added to ensure the robustness of the process.