Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CustomDateSummary result #425

Merged
merged 6 commits into from
Dec 13, 2018
Merged

Conversation

IvayloG
Copy link
Collaborator

@IvayloG IvayloG commented Dec 13, 2018

Closes #424

@IvayloG IvayloG requested a review from bazal4o December 13, 2018 12:18
@coveralls
Copy link

coveralls commented Dec 13, 2018

Coverage Status

Coverage remained the same at 88.041% when pulling 988582e on IGanchev/fix-grid-summaries-template into 2d10102 on master.

@@ -13,7 +13,7 @@ import { employeesData } from './localData';
export class GridSummariesComponent implements OnInit {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The classname should be templated. -> $(ClassName)Component

if you add two template with any name the build will fail.

@bazal4o bazal4o merged commit cb1e3c1 into master Dec 13, 2018
@bazal4o bazal4o deleted the IGanchev/fix-grid-summaries-template branch December 13, 2018 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants