Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add groupPriority to sort components within a group #331

Merged
merged 4 commits into from
Aug 3, 2018

Conversation

damyanpetev
Copy link
Member

Closes #303 .

Additional information related to this pull request:
Also bumping the Grid in Ignite UI for Angular back on top of the group

…roup #303

Also bumping the Grid in Ignite UI for Angular back on top of the group
@bazal4o
Copy link
Contributor

bazal4o commented Aug 2, 2018

@damyanpetev I think we need to have the ordering for the Groups too. By default Grids & Lists should be on top.

Copy link
Contributor

@bazal4o bazal4o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've a single comments/question

@coveralls
Copy link

coveralls commented Aug 2, 2018

Coverage Status

Coverage increased (+0.04%) to 88.545% when pulling 76aa019 on dpetev/groups-order into d779991 on master.

@damyanpetev
Copy link
Member Author

@bazal4o Yeah, problem is groups don't really exist on their own, they are produced from the components,
That won't be so easy to change, but I can start with making the Grids & List the default selection?

@bazal4o
Copy link
Contributor

bazal4o commented Aug 2, 2018

Yes make the Grids & Lits the default selection

bazal4o
bazal4o previously approved these changes Aug 2, 2018
@bazal4o bazal4o merged commit ef550c4 into master Aug 3, 2018
@bazal4o bazal4o deleted the dpetev/groups-order branch August 3, 2018 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants