Adding template for igxCombo #301
Conversation
| this.description = "Basic IgxCombo with templating"; | ||
| this.dependencies = [{ | ||
| from: "igniteui-angular", | ||
| import: ["IgxComboModule", "IgxDropDownModule", "IgxCheckboxModule", "IgxToggleModule", |
There was a problem hiding this comment.
Those imports seem a bit excessive - I don't see IgxIcon or button being used as stand-alone cpmponenets, just the <igx-combo> and some divs. So it should be enough to import just IgxComboModule combo, right?
| import { localData } from "./local-data"; | ||
|
|
||
| @Component({ | ||
| selector: 'app-$(filePrefix)', |
There was a problem hiding this comment.
Mixed tabs and spaces
Should be double space as indentation for this project.
|
|
||
| export class $(ClassName)Component implements OnInit { | ||
|
|
||
| public lData = localData; |
There was a problem hiding this comment.
You can still name that property localData if you want or you know - states or w/e.
|
@bazal4o My only issue is that now the Combo sits above Grid & List in the group and it should likely be in last place to keep the old order and match the one under https://www.infragistics.com/products/ignite-ui-angular Thinking of merging and maybe open up an issue for the ordering as that one will require some changes to the way we load templates. |
Closes #298 .