Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add search functionality and rename to crm-grid. #287 #288

Merged
merged 16 commits into from
Jul 18, 2018

Conversation

IvayloG
Copy link
Collaborator

@IvayloG IvayloG commented Jun 7, 2018

Closes #287 .

@IvayloG IvayloG requested a review from bazal4o June 7, 2018 11:19
@coveralls
Copy link

coveralls commented Jun 7, 2018

Coverage Status

Coverage remained the same at 88.575% when pulling 0f66609 on IGanchev/update-monster-to-crm into a072058 on master.

damyanpetev
damyanpetev previously approved these changes Jun 11, 2018
@@ -14,26 +12,20 @@ <h2 class="switch-sample__title">Boston Marathon 2018</h2>
</igx-input-group>
</div>

<igx-grid #grid1 [data]="localData" [paging]="true" [perPage]="6" height="513px" (onSelection)="cellSelection($event)" [paginationTemplate]="pager">
<igx-grid #grid1 [data]="localData" [paging]="true" [perPage]="6" [height]="null" (onSelection)="cellSelection($event)" [paginationTemplate]="pager">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[height]="null" ?

Copy link
Member

@damyanpetev damyanpetev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The buttons on the CRM Grid toolbar look weird (contrasty) and the dropdown portion is lacking styling, so it seems the styles are not the latest.

@bazal4o bazal4o merged commit 992bda3 into master Jul 18, 2018
@bazal4o bazal4o deleted the IGanchev/update-monster-to-crm branch July 18, 2018 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants