feat: add doc command #66 #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damyanpetev
reviewed
Mar 7, 2018
lib/PromptSession.ts
Outdated
| @@ -265,3 +265,20 @@ export class PromptSession { | |||
| return answers; | |||
| } | |||
| } | |||
|
|
|||
| export function chooseTerm() { | |||
| return inquirer.prompt({ | |||
There was a problem hiding this comment.
you can use await to cut down on promise handlers :)
const answers = await inquirer.prompt(...
damyanpetev
reviewed
Mar 7, 2018
lib/PromptSession.ts
Outdated
| @@ -265,3 +265,20 @@ export class PromptSession { | |||
| return answers; | |||
| } | |||
| } | |||
|
|
|||
| export function chooseTerm() { | |||
There was a problem hiding this comment.
And this one should be marked as async really (though await will force it anyway)
Just for style sake, I'd prefer if the extra function was part of the class itself (matching exported class to file name thing), could be static.
damyanpetev
requested changes
Mar 7, 2018
lib/commands/doc.ts
Outdated
| } else { | ||
| Util.error(`Review your search results in the browser`, "green"); | ||
| return (argv.extended) ? | ||
| doc.open(`https://www.google.com/search?q=site%3Aigniteui.com\\%20infragistics.com+${argv.term}`) : |
lib/commands/doc.ts
Outdated
| }, | ||
| async execute(argv) { | ||
| if (!argv.term) { | ||
| await chooseTerm().then(answer => { |
There was a problem hiding this comment.
no need for then if you use await
2984585 to
bf61a1a
Compare
Closes #66
bf61a1a to
d19ef81
Compare
damyanpetev
approved these changes
Mar 7, 2018
bazal4o
approved these changes
Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#66
Add doc command, allowing users to search the infragistics help for a given term