Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ng): use "skipLibCheck": true for legacy igx projects #1328

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

Lipata
Copy link
Member

@Lipata Lipata commented Oct 28, 2024

The skipLibCheck property is also defined in the standalone templates.

The problem was caught in the CodeGen angular module generated project, where there was a problem with the igniteui-webcomponents library (which is used by igniteui-angular, because the of the wc rating). igniteui-webcomponents is using typescript@5.6. while igniteui-angular is using typescript@5.5 and the following error is shown:

Error: node_modules/igniteui-webcomponents/components/icon/registry/default-map.d.ts:10:16 - error TS2552: Cannot find name 'MapIterator'. Did you mean 'Iterator'?        

10     entries(): MapIterator<[T, U]>;
                  ~~~~~~~~~~~

This is a Typescript API change from 5.5 to 5.6 and because the problem is not related to the generated angular project and it is running successfully, then skipLibCheck: true is a proper solution.

@Lipata Lipata requested review from valadzhov and Hristo313 October 28, 2024 09:13
@coveralls
Copy link

Coverage Status

coverage: 70.414%. remained the same
when pulling 1a955f6 on nalipiev/skip-lib-ng
into aa469c3 on master.

@Lipata Lipata changed the title chore: use "skipLibCheck": true for legacy igx projects fix: use "skipLibCheck": true for legacy igx projects Oct 28, 2024
@Lipata Lipata changed the title fix: use "skipLibCheck": true for legacy igx projects fix(ng): use "skipLibCheck": true for legacy igx projects Oct 28, 2024
@Lipata Lipata merged commit 43cfacc into master Oct 28, 2024
3 checks passed
@Lipata Lipata deleted the nalipiev/skip-lib-ng branch October 28, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants