Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update wc, react and dock-manager #1321

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

Lipata
Copy link
Member

@Lipata Lipata commented Oct 3, 2024

Update old references in the templates

@coveralls
Copy link

coveralls commented Oct 3, 2024

Coverage Status

coverage: 70.407%. remained the same
when pulling 9508368 on nalipiev/update-wc-dock
into ee2782e on master.

valadzhov
valadzhov previously approved these changes Oct 4, 2024
Copy link
Member

@jackofdiamond5 jackofdiamond5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For WC I get
image

This is because the igc-form component has been removed in IgniteUI/igniteui-webcomponents#1281, IgniteUI/igniteui-webcomponents#1302 so we need to use the native form in our templates.

Copy link
Member

@jackofdiamond5 jackofdiamond5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a little problem with the radio group, where you can select more than one option. But this is not necessarily related to this PR.

@jackofdiamond5 jackofdiamond5 merged commit aa5a6a5 into master Oct 11, 2024
3 checks passed
@jackofdiamond5 jackofdiamond5 deleted the nalipiev/update-wc-dock branch October 11, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants