Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(igx): enable back strict true #1090

Merged
merged 5 commits into from
Jun 2, 2023
Merged

chore(igx): enable back strict true #1090

merged 5 commits into from
Jun 2, 2023

Conversation

Lipata
Copy link
Member

@Lipata Lipata commented Nov 22, 2022

No description provided.

@coveralls
Copy link

coveralls commented Nov 22, 2022

Coverage Status

coverage: 70.404%. remained the same when pulling c0de4c5 on nalipiev/revert into 8d429c0 on 12.0.x.

@@ -277,7 +277,7 @@
case "npm":
/* passes through */
default:
return `${managerCommand} install ${packageName} --force --quiet --save`;
return `${managerCommand} install ${packageName} --quiet --save`;

Check warning

Code scanning / CodeQL

Unsafe shell command constructed from library input

[String concatenation](1) which depends on [library input](2) is later used in [a shell command](3). [String concatenation](1) which depends on [library input](4) is later used in [a shell command](3). [String concatenation](1) which depends on [library input](5) is later used in [a shell command](3).
@github-actions
Copy link

There has been no recent activity and this PR has been marked inactive.

@Lipata Lipata changed the base branch from master to 12.0.x May 26, 2023 13:55
@Lipata Lipata changed the title chore: revert temporary workarounds chore(igx): enable back strict true Jun 2, 2023
@Lipata Lipata merged commit 0575ea7 into 12.0.x Jun 2, 2023
@Lipata Lipata deleted the nalipiev/revert branch June 2, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants