Pass in options for wc child process #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lipata
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #972
Additional information related to this pull request: For
execSyncwe need to provide options which specifystdioandkillSignal. Currently we make the child process inherit thestdioof its parent so that it can print messages to itsstdoutand we set thekillSignalto beSIGINTallowing it to handle its termination gracefully. Because we also inherit thestdinthis may cause trouble if the child process throws during interruption and there will be no real way for us to handle it. A future improvement may be to consider piping the child process'stdinin order to keep the control with us. However, we will have to support any inputs required for every child process that we spawn.