Skip to content

Commit

Permalink
update node version in yml files and fix build logic for angular temp…
Browse files Browse the repository at this point in the history
…lates (#1330)
  • Loading branch information
Hristo313 authored Nov 6, 2024
1 parent af04fe6 commit 085bf44
Show file tree
Hide file tree
Showing 12 changed files with 36 additions and 30 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ on:

jobs:
build-and-deploy:

# Deactivate the workflow. Will be changed when AB is ready
if: false
runs-on: ubuntu-latest

permissions:
Expand All @@ -17,7 +18,7 @@ jobs:

strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [22.x]

steps:
- uses: actions/checkout@v3
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [22.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ on:

jobs:
build-and-deploy:

# Deactivate the workflow. Will be changed when AB is ready
if: false
runs-on: ubuntu-latest

permissions:
Expand All @@ -17,7 +18,7 @@ jobs:

strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [22.x]

steps:
- uses: actions/checkout@v3
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [22.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ on:

jobs:
build-and-deploy:

# Deactivate the workflow. Will be changed when AB is ready
if: false
runs-on: ubuntu-latest

permissions:
Expand All @@ -17,7 +18,7 @@ jobs:

strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [22.x]

steps:
- uses: actions/checkout@v3
Expand All @@ -31,10 +32,10 @@ jobs:
run: echo "PROJECT_NAME=$(jq -r '.name' package.json)" >> $GITHUB_ENV
- name: Determine if project is standalone and set build path
run: |
if jq -e ".projects[\"${{ env.PROJECT_NAME }}\"].schematics[\"@schematics/angular:application\"].standalone == false" angular.json > /dev/null; then
echo "BUILD_PATH=./dist/${{ env.PROJECT_NAME }}" >> $GITHUB_ENV
else
if jq -e ".projects[\"${{ env.PROJECT_NAME }}\"].architect.build.builder == \"@angular-devkit/build-angular:application\"" angular.json > /dev/null; then
echo "BUILD_PATH=./dist/${{ env.PROJECT_NAME }}/browser" >> $GITHUB_ENV
else
echo "BUILD_PATH=./dist/${{ env.PROJECT_NAME }}" >> $GITHUB_ENV
fi
- name: Build project with dynamic base-href
run: npm run build -- --base-href "/${{ github.event.repository.name }}/"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:

strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [22.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ on:

jobs:
build-and-deploy:

# Deactivate the workflow. Will be changed when AB is ready
if: false
runs-on: ubuntu-latest

permissions:
Expand All @@ -17,7 +18,7 @@ jobs:

strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [22.x]

steps:
- uses: actions/checkout@v3
Expand All @@ -31,10 +32,10 @@ jobs:
run: echo "PROJECT_NAME=$(jq -r '.name' package.json)" >> $GITHUB_ENV
- name: Determine if project is standalone and set build path
run: |
if jq -e ".projects[\"${{ env.PROJECT_NAME }}\"].schematics[\"@schematics/angular:application\"].standalone == false" angular.json > /dev/null; then
echo "BUILD_PATH=./dist/${{ env.PROJECT_NAME }}" >> $GITHUB_ENV
else
if jq -e ".projects[\"${{ env.PROJECT_NAME }}\"].architect.build.builder == \"@angular-devkit/build-angular:application\"" angular.json > /dev/null; then
echo "BUILD_PATH=./dist/${{ env.PROJECT_NAME }}/browser" >> $GITHUB_ENV
else
echo "BUILD_PATH=./dist/${{ env.PROJECT_NAME }}" >> $GITHUB_ENV
fi
- name: Build project with dynamic base-href
run: npm run build -- --base-href "/${{ github.event.repository.name }}/"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:

strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [22.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ on:

jobs:
build-and-deploy:

# Deactivate the workflow. Will be changed when AB is ready
if: false
runs-on: ubuntu-latest

permissions:
Expand All @@ -17,7 +18,7 @@ jobs:

strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [22.x]

steps:
- uses: actions/checkout@v3
Expand All @@ -31,10 +32,10 @@ jobs:
run: echo "PROJECT_NAME=$(jq -r '.name' package.json)" >> $GITHUB_ENV
- name: Determine if project is standalone and set build path
run: |
if jq -e ".projects[\"${{ env.PROJECT_NAME }}\"].schematics[\"@schematics/angular:application\"].standalone == false" angular.json > /dev/null; then
echo "BUILD_PATH=./dist/${{ env.PROJECT_NAME }}" >> $GITHUB_ENV
else
if jq -e ".projects[\"${{ env.PROJECT_NAME }}\"].architect.build.builder == \"@angular-devkit/build-angular:application\"" angular.json > /dev/null; then
echo "BUILD_PATH=./dist/${{ env.PROJECT_NAME }}/browser" >> $GITHUB_ENV
else
echo "BUILD_PATH=./dist/${{ env.PROJECT_NAME }}" >> $GITHUB_ENV
fi
- name: Build project with dynamic base-href
run: npm run build -- --base-href "/${{ github.event.repository.name }}/"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:

strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [22.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ on:

jobs:
build-and-deploy:

# Deactivate the workflow. Will be changed when AB is ready
if: false
runs-on: ubuntu-latest

permissions:
Expand All @@ -17,7 +18,7 @@ jobs:

strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [22.x]

steps:
- uses: actions/checkout@v3
Expand All @@ -31,10 +32,10 @@ jobs:
run: echo "PROJECT_NAME=$(jq -r '.name' package.json)" >> $GITHUB_ENV
- name: Determine if project is standalone and set build path
run: |
if jq -e ".projects[\"${{ env.PROJECT_NAME }}\"].schematics[\"@schematics/angular:application\"].standalone == false" angular.json > /dev/null; then
echo "BUILD_PATH=./dist/${{ env.PROJECT_NAME }}" >> $GITHUB_ENV
else
if jq -e ".projects[\"${{ env.PROJECT_NAME }}\"].architect.build.builder == \"@angular-devkit/build-angular:application\"" angular.json > /dev/null; then
echo "BUILD_PATH=./dist/${{ env.PROJECT_NAME }}/browser" >> $GITHUB_ENV
else
echo "BUILD_PATH=./dist/${{ env.PROJECT_NAME }}" >> $GITHUB_ENV
fi
- name: Build project with dynamic base-href
run: npm run build -- --base-href "/${{ github.event.repository.name }}/"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:

strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [22.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
Expand Down

0 comments on commit 085bf44

Please sign in to comment.