Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing combo data source using knockout observable is not working #1852

Closed
Lipata opened this issue Nov 30, 2018 · 0 comments
Closed

Changing combo data source using knockout observable is not working #1852

Lipata opened this issue Nov 30, 2018 · 0 comments
Assignees
@Lipata
Labels
bug combo knockout severity: high status: resolved version: 17.2 version: 18.1 version: 18.2 version: 19.1

Comments

@Lipata
Copy link
Member

Lipata commented Nov 30, 2018

Description

Changing combo data source, using knockout observable, is not working when new data source length is the same as old one

Steps to reproduce

  1. Open attached demo
  2. Press "Change datasource to 6" button

Result

Combo list stays unchanges

Expected result

Combo list should be updated with the new value

Attachments

igComboEx.zip
@Lipata Lipata self-assigned this Nov 30, 2018
@bazal4o bazal4o added the bug label Dec 5, 2018
Lipata added a commit that referenced this issue Dec 6, 2018
@Lipata
test(combo knockout): update ds when new ds length is the same #1852
7fe463e
@Lipata Lipata mentioned this issue Dec 6, 2018
Merged
Lipata added a commit that referenced this issue Dec 6, 2018
@Lipata
fix(combo knockout): update ds when new ds length is the same #1852
d30a3af
Lipata added a commit that referenced this issue Dec 6, 2018
@Lipata
test(combo knockout): update ds when new ds length is the same #1852
34b8cea
@Lipata Lipata mentioned this issue Dec 6, 2018
Merged
Lipata added a commit that referenced this issue Dec 6, 2018
@Lipata
fix(combo knockout): update ds when new ds length is the same #1852
125fa46
Lipata added a commit that referenced this issue Dec 6, 2018
@Lipata
chore(combo knockout): fix jshint errors #1852
16bf8ab
Lipata added a commit that referenced this issue Dec 7, 2018
@Lipata
refactor(combo knockout): refactor isNewDataSource #1852
debe101
Lipata added a commit that referenced this issue Dec 7, 2018
@Lipata
refactor(combo knockout): refactor isNewDataSource method #1852
82d5f2e
Lipata added a commit that referenced this issue Dec 7, 2018
@Lipata
test(combo knockout): refactor test #1852
8e1ad3d
Lipata added a commit that referenced this issue Dec 7, 2018
@Lipata
fix(combo knockout): update ds when new ds length is the same #1852
86e4590
@Lipata Lipata mentioned this issue Dec 7, 2018
Merged
Lipata added a commit that referenced this issue Dec 7, 2018
@Lipata
fix(combo knockout): update ds when new ds length is the same #1852
b11b98b
Lipata added a commit that referenced this issue Dec 7, 2018
@Lipata
refactor(combo-knockout): jshint errors #1852
9e87372
Lipata added a commit that referenced this issue Dec 7, 2018
@Lipata
refactor(combo kncokout): jshint errors #1852
c1bb2b9
Lipata added a commit that referenced this issue Dec 7, 2018
@Lipata
fix(combo knockout): update ds when new ds length is the same #1852
3001f4e
@Lipata Lipata mentioned this issue Dec 7, 2018
Merged
Lipata added a commit that referenced this issue Dec 7, 2018
@Lipata
refactor(combo knockout): fix jshint #1852
e3e3c1e
Lipata added a commit that referenced this issue Dec 7, 2018
@Lipata
refactor(combo knockout): fix jshint #1852
d0143d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lipata Lipata

Labels
bug combo knockout severity: high status: resolved version: 17.2 version: 18.1 version: 18.2 version: 19.1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Lipata @bazal4o