Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError is thrown when IME is enabled and a number is typed #1695

Closed
ymita opened this issue Apr 10, 2018 · 3 comments
Closed

Uncaught TypeError is thrown when IME is enabled and a number is typed #1695

ymita opened this issue Apr 10, 2018 · 3 comments

Comments

@ymita
Copy link
Contributor

ymita commented Apr 10, 2018

Description

Uncaught TypeError is thrown when IME is enabled and a number is typed

Steps to reproduce

  1. Run the attached sample
  2. Enable Japanese IME mode
  3. Type "2" on the igDatePicker

Result

The following error is thrown:
Uncaught TypeError: Cannot read property 'toString' of null

Expected result

No error is thrown.

Attachments

igDatePicker_test.zip

Note

This is reproduced in 17.1 and 17.2.

@kdinev
Copy link
Member

kdinev commented Apr 12, 2018

@ymita I added you to the product team, so you can apply labels. Please put all the applicable versions for this bug.

@ymita
Copy link
Contributor Author

ymita commented May 2, 2018

@kdinev Thanks for inviting me to the team. I added version labels.

@damyanpetev
Copy link
Member

Reproducible only with IME and dataMode:"editModeText" and doesn't interfere with the editor value in the end.
The error is caused by the attempt to sync the calendar while typing, which doesn't make too much sense when using IME composition because the value is not converted/assigned to the mask until confirmed and so the required positions can't be validated anyway.

For now disabling the calendar sync until composition value is confirmed seems a reasonable solution.

bazal4o added a commit that referenced this issue Sep 26, 2018
…or-17.2

#1695 Prevent parsing invalid date produced with IME input
bazal4o added a commit that referenced this issue Sep 26, 2018
…or-18.2

#1695 Prevent parsing invalid date produced with IME input
bazal4o added a commit that referenced this issue Sep 26, 2018
…or-18.1

#1695 Prevent parsing invalid date produced with IME input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants