Merge pull request #2137 from IgniteUI/sstoychev/cherrypick-use-stric…

…t-21.1 feat(*): adding use strict to JS files 21.1
IgniteUI · Aug 17, 2021 · f010b21 · f010b21
2 parents 156cc3a + 804a486
commit f010b21
Show file tree

Hide file tree

Showing 36 changed files with 55 additions and 35 deletions.
diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml
@@ -16,7 +16,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [10.x, 12.x, 14.x, 15.x]
+        node-version: [12.x, 14.x, 15.x]
         # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
 
     steps:

diff --git a/demos/tree/api-and-events.html b/demos/tree/api-and-events.html
@@ -1,5 +1,5 @@
 <!DOCTYPE html>
-<html>
+<html lang="en">
 <head>
     <title>API and Events Sample - API and Events with Tree Control - Ignite UI for jQuery�</title>
 

diff --git a/package.json b/package.json
@@ -19,7 +19,8 @@
   "scripts": {
     "test": "karma start",
     "cover": "grunt hint && npm test -- --single-run",
-    "postinstall": "npm install -g grunt-cli"
+    "postinstall": "npm install -g grunt-cli",
+    "build": "grunt build"
   },
   "dependencies": {
     "jquery": "^3.6.0",

diff --git a/src/js/extensions/infragistics.ui.combo.knockout-extensions.js b/src/js/extensions/infragistics.ui.combo.knockout-extensions.js
@@ -12,6 +12,7 @@
 */
 
 /*global ko*/
+"use strict";
 (function (factory) {
 	if (typeof define === "function" && define.amd) {
 		define( [

diff --git a/src/js/extensions/infragistics.ui.editors.knockout-extensions.js b/src/js/extensions/infragistics.ui.editors.knockout-extensions.js
@@ -13,6 +13,7 @@
 */
 
 /*global ko*/
+"use strict";
 (function (factory) {
 	if (typeof define === "function" && define.amd) {
 		define( [

diff --git a/src/js/extensions/infragistics.ui.tree.knockout-extensions.js b/src/js/extensions/infragistics.ui.tree.knockout-extensions.js
@@ -20,6 +20,7 @@
  */
 
 /*global ko*/
+"use strict";
 (function (factory) {
 	if (typeof define === "function" && define.amd) {
 		define( [

diff --git a/src/js/infragistics.loader.js b/src/js/infragistics.loader.js
@@ -5,7 +5,7 @@
 * http://www.infragistics.com/
 *
 */
-
+"use strict";
 if (typeof jQuery !== "function") {
 	throw new Error("jQuery is undefined");
 }

diff --git a/src/js/modules/infragistics.datasource.js b/src/js/modules/infragistics.datasource.js
@@ -27,6 +27,7 @@
  */
 
 /*global Class, ActiveXObject, DOMParser, XPathResult, XMLSerializer */
+"use strict";
 (function (factory) {
 	if (typeof define === "function" && define.amd) {
 

diff --git a/src/js/modules/infragistics.templating.js b/src/js/modules/infragistics.templating.js
@@ -20,7 +20,7 @@
 		e.g. {{if condition}} do something {{else}} do something else {{/if}}
 		limitation: Regular expressions are equivalent to finite automatons as described by theory of computation and more precisely the formal languages and automata computability theory. This means that they are limited to recognizing languages of the type AB^nC but noy languages of the type [AB]^n which are recognized by context-free grammars (Regular expressions are still a subset of context-free grammars). However the A^nB^n is recognized due to the fact that we can use greedy regular expressions allowing us to match the last existing token of a type. Thus nested if-statements would not be recognized without stack-tokenizing the block statement.
  */
-
+"use strict";
 (function (factory) {
 	if (typeof define === "function" && define.amd) {
 

diff --git a/src/js/modules/infragistics.ui.colorpicker.js b/src/js/modules/infragistics.ui.colorpicker.js
@@ -14,7 +14,7 @@
  *   infragistics.util.jquery.js
  *   infragistics.ui.shared.js
  */
-
+"use strict";
 (function (factory) {
 	if (typeof define === "function" && define.amd) {
 

diff --git a/src/js/modules/infragistics.ui.colorpickersplitbutton.js b/src/js/modules/infragistics.ui.colorpickersplitbutton.js
@@ -18,7 +18,7 @@
  *   infragistics.ui.splitbutton.js
  *   infragistics.ui.colorpicker.js
  */
-
+"use strict";
 (function (factory) {
 	if (typeof define === "function" && define.amd) {
 

diff --git a/src/js/modules/infragistics.ui.combo.js b/src/js/modules/infragistics.ui.combo.js
@@ -23,7 +23,7 @@
 *   </script>
 *   <input id="combo" />
 */
-
+"use strict";
 (function (factory) {
 	if (typeof define === "function" && define.amd) {
 

diff --git a/src/js/modules/infragistics.ui.dialog.js b/src/js/modules/infragistics.ui.dialog.js
@@ -25,7 +25,7 @@
 *	</script>
 *	<div id="dialog1"></div>
 */
-
+"use strict";
 (function (factory) {
 	if (typeof define === "function" && define.amd) {
 

diff --git a/src/js/modules/infragistics.ui.editors.js b/src/js/modules/infragistics.ui.editors.js
@@ -15,7 +15,7 @@
  *  infragistics.ui.notifier.js
  *	infragistics.ui.validator.js
  */
-
+"use strict";
 (function (factory) {
 	if (typeof define === "function" && define.amd) {
 

diff --git a/src/js/modules/infragistics.ui.htmleditor.js b/src/js/modules/infragistics.ui.htmleditor.js
@@ -25,6 +25,7 @@
  */
 
 /*global Class*/
+"use strict";
 (function (factory) {
     if (typeof define === "function" && define.amd) {
 

diff --git a/src/js/modules/infragistics.ui.layoutmanager.js b/src/js/modules/infragistics.ui.layoutmanager.js
@@ -12,7 +12,7 @@
 *	infragistics.util.js
 *   infragistics.util.jquery.js
 */
-
+"use strict";
 (function (factory) {
     if (typeof define === "function" && define.amd) {
 

diff --git a/src/js/modules/infragistics.ui.notifier.js b/src/js/modules/infragistics.ui.notifier.js
@@ -14,7 +14,7 @@
 *  infragistics.ui.widget.js
 *  infragistics.ui.popover.js
 */
-
+"use strict";
 (function (factory) {
 	if (typeof define === "function" && define.amd) {
 

diff --git a/src/js/modules/infragistics.ui.popover.js b/src/js/modules/infragistics.ui.popover.js
@@ -15,6 +15,7 @@
  */
 
 /*global HTMLElement */
+"use strict";
 (function (factory) {
 	if (typeof define === "function" && define.amd) {
 

diff --git a/src/js/modules/infragistics.ui.rating.js b/src/js/modules/infragistics.ui.rating.js
@@ -22,7 +22,7 @@
 *	</script>
 *	<div id="rating1"></div>
 */
-
+"use strict";
 (function (factory) {
 	if (typeof define === "function" && define.amd) {
 

diff --git a/src/js/modules/infragistics.ui.scroll.js b/src/js/modules/infragistics.ui.scroll.js
@@ -15,6 +15,7 @@
 */
 
 /*global MSGesture*/
+"use strict";
 (function (factory) {
 	if (typeof define === "function" && define.amd) {
 

diff --git a/src/js/modules/infragistics.ui.shared.js b/src/js/modules/infragistics.ui.shared.js
@@ -12,7 +12,7 @@
  *	infragistics.util.js
  *  infragistics.util.jquery.js
  */
-
+"use strict";
 (function (factory) {
 	if (typeof define === "function" && define.amd) {
 

diff --git a/src/js/modules/infragistics.ui.splitbutton.js b/src/js/modules/infragistics.ui.splitbutton.js
@@ -15,7 +15,7 @@
  *   infragistics.ui.shared.js
  *   infragistics.ui.toolbarbutton.js
  */
-
+"use strict";
 (function (factory) {
 	if (typeof define === "function" && define.amd) {
 

diff --git a/src/js/modules/infragistics.ui.splitter.js b/src/js/modules/infragistics.ui.splitter.js
@@ -14,7 +14,7 @@
  *  infragistics.ui.widget.js
  *	infragistics.ui.splitter-en.js
  */
-
+"use strict";
 (function (factory) {
     if (typeof define === "function" && define.amd) {
 

diff --git a/src/js/modules/infragistics.ui.tilemanager.js b/src/js/modules/infragistics.ui.tilemanager.js
@@ -18,7 +18,7 @@
  *	infragistics.ui.layoutmanager.js
  *	infragistics.ui.tilemanager-en.js
  */
-
+"use strict";
 (function (factory) {
 	if (typeof define === "function" && define.amd) {
 

diff --git a/src/js/modules/infragistics.ui.toolbar.js b/src/js/modules/infragistics.ui.toolbar.js
@@ -23,6 +23,7 @@
  */
 
 /*global Class */
+"use strict";
 (function (factory) {
 	if (typeof define === "function" && define.amd) {
 

diff --git a/src/js/modules/infragistics.ui.toolbarbutton.js b/src/js/modules/infragistics.ui.toolbarbutton.js
@@ -13,7 +13,7 @@
  *  infragistics.util.jquery.js
  *	infragistics.ui.shared.js
  */
-
+"use strict";
 (function (factory) {
 	if (typeof define === "function" && define.amd) {
 

diff --git a/src/js/modules/infragistics.ui.tree.js b/src/js/modules/infragistics.ui.tree.js
@@ -19,7 +19,7 @@
  *  infragistics.ui.widget.js
  *	infragistics.ui.tree-en.js
  */
-
+"use strict";
 (function (factory) {
 	if (typeof define === "function" && define.amd) {
 

diff --git a/src/js/modules/infragistics.ui.upload.js b/src/js/modules/infragistics.ui.upload.js
@@ -14,7 +14,7 @@
  *  infragistics.ui.widget.js
  *  infragistics.ui.shared.js
  */
-
+"use strict";
 (function (factory) {
 	if (typeof define === "function" && define.amd) {
 

diff --git a/src/js/modules/infragistics.ui.validator.js b/src/js/modules/infragistics.ui.validator.js
@@ -24,6 +24,7 @@
 */
 
 /*global Class */
+"use strict";
 (function (factory) {
 	if (typeof define === "function" && define.amd) {
 

diff --git a/src/js/modules/infragistics.ui.videoplayer.js b/src/js/modules/infragistics.ui.videoplayer.js
@@ -14,7 +14,7 @@
  *  infragistics.ui.widget.js
  *  infragistics.ui.shared.js
  */
-
+"use strict";
 (function (factory) {
 	if (typeof define === "function" && define.amd) {
 

diff --git a/src/js/modules/infragistics.ui.widget.js b/src/js/modules/infragistics.ui.widget.js
@@ -13,7 +13,7 @@
  *   infragistics.util.js
  *   infragistics.util.jquery.js
  */
-
+"use strict";
 (function (factory) {
 	if (typeof define === "function" && define.amd) {
 

diff --git a/src/js/modules/infragistics.ui.zoombar.js b/src/js/modules/infragistics.ui.zoombar.js
@@ -16,6 +16,7 @@
 */
 
 /*global Class */
+"use strict";
 (function (factory) {
 	if (typeof define === "function" && define.amd) {
 

diff --git a/src/js/modules/infragistics.util.jquery.js b/src/js/modules/infragistics.util.jquery.js
@@ -15,7 +15,6 @@
  *
  */
 /*global xyz, Class, ActiveXObject, Modernizr, VBArray, Intl, XDomainRequest, unescape*/ /*jshint -W106*/ /*jshint -W116*/ /*jshint unused:false*/
-
 (function (factory) {
 	if (typeof define === "function" && define.amd) {
 

diff --git a/src/js/modules/infragistics.util.js b/src/js/modules/infragistics.util.js
@@ -20,6 +20,7 @@
 // Inspired by base2 and Prototype
 
 /*global xyz, Class, ActiveXObject, Modernizr, VBArray, Intl, XDomainRequest, unescape, $, igRoot*/ /*jshint -W106*/ /*jshint -W116*/ /*jshint unused:false*/
+"use strict";
 (function (factory) {
 	if (typeof define === "function" && define.amd) {
 
@@ -55,7 +56,7 @@
 
 	// The base Class implementation (does nothing) or expects Class to already be defined as a function
 	// K.D. August 18, 2016 Bug #242 global scope Class object is overridden by Ignite UI for jQuery Class object
-	this.Class = this.Class || function () { };
+	window.Class = window.Class || function () { };
 
 	// Create a new Class that inherits from this class
 	Class.extend = function (prop, doAugment) {
@@ -1531,17 +1532,26 @@
 	}
 
 	// polyfill for IE11+. ChildNode.remove() is not supported by IE11+.
-	function removePolyfillIE() {
-		return this.parentNode && this.parentNode.removeChild(this);
-	}
-
-	// polyfill for IE11+. ChildNode.remove() is not supported by IE11+.
-	if (!Element.prototype.remove) {
-		Element.prototype.remove = removePolyfillIE;
+	if (!Element.hasOwnProperty("remove")) {
+		Object.defineProperty(Element, 'remove', {
+			configurable: true,
+			enumerable: true,
+			writable: true,
+			value: function remove() {
+			  	this.parentNode.removeChild(this);
+			}
+		});
 	}
 
-	if (Text && !Text.prototype.remove) {
-		Text.prototype.remove = removePolyfillIE;
+	if (Text && !Text.hasOwnProperty("remove")) {
+		Object.defineProperty(Text, 'remove', {
+			configurable: true,
+			enumerable: true,
+			writable: true,
+			value: function remove() {
+			  	this.parentNode.removeChild(this);
+			}
+		});
 	}
 
 	$.ig.Date.prototype.toStringFormat = function (value, format, provider) {

diff --git a/tests/unit/scroll/scroll-test.js b/tests/unit/scroll/scroll-test.js
@@ -1734,7 +1734,7 @@ QUnit.test(testId_57, function (assert) {
             scrollbarPixelContentRatio = (self.vhScroll().height() / (contentHeight - scrollContainerHeight)) * (vTrackHeight - vDragHeight),
             expectedPosY = self.getTransform3dValueY(self.vDrag(self.vhScrollId));
 
-        assert.equal(expectedPosY.toFixed(4), scrollbarPixelContentRatio.toFixed(4), "igScroll did not scroll properly");
+        assert.equal(expectedPosY.toFixed(2), scrollbarPixelContentRatio.toFixed(2), "igScroll did not scroll properly");
         self.vhScroll().remove();
         done();
     }).catch(function (er) {

diff --git a/tests/unit/tilemanager/tilemanager/tilemanager-test.js b/tests/unit/tilemanager/tilemanager/tilemanager-test.js
@@ -1071,7 +1071,7 @@ QUnit.test('[ID2] igTileManager initialize on markup. Default config', function
 });
 
 
-QUnit.test('[ID3] iigTileManager initialize on markup. ColumnWidth and columnHeight in px', function (assert) {
+QUnit.test('[ID3] igTileManager initialize on markup. ColumnWidth and columnHeight in px', function (assert) {
 	assert.expect(660);
 	this.assert = assert;
-Original file line number
+Diff line change
@@ Expand Up / @@ -15,7 +15,6 @@ @@
      *
      */
     /*global xyz, Class, ActiveXObject, Modernizr, VBArray, Intl, XDomainRequest, unescape*/ /*jshint -W106*/ /*jshint -W116*/ /*jshint unused:false*/
     (function (factory) {
     	if (typeof define === "function" && define.amd) {
@@ Expand Down @@