forked from bvaughn/react-virtualized
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge remote-tracking branch 'bvaughn/master' into invalidate-caches
* bvaughn/master: (54 commits) Update version and changelog for 9.21.0 release (bvaughn#1252) chore: update lockfile Update ci badge (bvaughn#1227) Allow users to override default table row styles (bvaughn#1175) Add onColumnClick to Table (bvaughn#1207) remove unused variable in Masonry.example.js (bvaughn#1218) Fix Table aria attributes (bvaughn#1208) Fix typo in CellMeasurer.DynamicHeightTableColumn.example.js (bvaughn#1190) Update usingAutoSizer.md (bvaughn#1186) Add an extra check for an e.target.className.indexOf function (bvaughn#1210) Fix broken Slack badge image (bvaughn#1205) docs(CellMeasurer): fix `import` statement (bvaughn#1187) Added new friend (bvaughn#1197) Fix createMultiSort bug (bvaughn#1051) adding new usecase example and fix some typos (bvaughn#1168) Updating version to 9.20.1 Update changelog for the 9.20.1 release (bvaughn#1167) Prevent early debounceScrollEndedCallback when there is a slow render (bvaughn#1141) removing sideEffects (bvaughn#1163) fix for bvaughn#998 with test cases (bvaughn#1154) ...
- Loading branch information
Showing
48 changed files
with
4,042 additions
and
1,020 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
## Asking a Question? | ||
|
||
Please don't file GitHub issues to ask questions! Instead use: | ||
* Stack Overflow: http://stackoverflow.com/questions/tagged/react-virtualized | ||
* The react-virtualized Slack channel: https://react-virtualized.now.sh | ||
|
||
### Do you want to request a *feature* or report a *bug*? | ||
|
||
Requesting a feature? | ||
|
||
Provide as much information as possible about your requested feature. Here are a few questions you may consider answering: | ||
|
||
* What's your use case? (Tell me about your application and what problem you're trying to solve.) | ||
* What interface do you have in mind? (What new properties or methods do you think might be helpful?) | ||
* Can you point to similar functionality with any existing libraries or components? (Working demos can be helpful.) | ||
|
||
Reporting a Bug? | ||
|
||
Please include either a failing unit test or a simple repro. You can start by forking this Code Sandbox: https://codesandbox.io/s/03qpzq1p9p?module=%2FExample.js | ||
|
||
### What is the current behavior? | ||
|
||
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React and react-virtualized. Paste the link to your [Code Sandbox](https://codesandbox.io/s/03qpzq1p9p?module=%2FExample.js) below: | ||
|
||
### What is the expected behavior? | ||
|
||
### Which versions of React and react-virtualized, and which browser / OS are affected by this issue? Did this work in previous versions of react-virtualized? | ||
| | | | ||
|-------------------|----------| | ||
| Browser | | | ||
| OS | | | ||
| React | | | ||
| React DOM | | | ||
| react-virtualized | | |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
Thanks for contributing to react-virtualized! | ||
|
||
**Before submitting a pull request,** please complete the following checklist: | ||
|
||
- [ ] The existing test suites (`npm test`) all pass | ||
- [ ] For any new features or bug fixes, both positive and negative test cases have been added | ||
- [ ] For any new features, documentation has been added | ||
- [ ] For any documentation changes, the text has been proofread and is clear to both experienced users and beginners. | ||
- [ ] Format your code with [prettier](https://github.com/prettier/prettier) (`npm run prettier`). | ||
- [ ] Run the [Flow](https://flowtype.org/) typechecks (`npm run typecheck`). | ||
|
||
Here is a short checklist of additional things to keep in mind before submitting: | ||
* Please make sure your pull request description makes it very clear what you're trying to accomplish. If it's a bug fix, please also provide a failing test case (if possible). In either case, please add additional unit test coverage for your changes. :) | ||
* Be sure you have notifications setup so that you'll see my code review responses. (I may ask you to make some adjustments before merging.) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,3 +6,4 @@ node_modules | |
npm-debug.log | ||
styles.css | ||
.vscode | ||
.idea |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.